Merged in feature-pom-new-plugins (pull request #3)

Added new dependencies

Approved-by: Guillem Hernandez Sola <guillem.hernandez.sola@gmail.com>

.gitignore

@@ -1,3 +1,149 @@
 .idea
 *.iml
 target
+
+
+# Created by https://www.toptal.com/developers/gitignore/api/visualstudiocode,maven,java,jetbrains+all
+# Edit at https://www.toptal.com/developers/gitignore?templates=visualstudiocode,maven,java,jetbrains+all
+
+### Java ###
+# Compiled class file
+*.class
+
+# Log file
+*.log
+
+# BlueJ files
+*.ctxt
+
+# Mobile Tools for Java (J2ME)
+.mtj.tmp/
+
+# Package Files #
+*.jar
+*.war
+*.nar
+*.ear
+*.zip
+*.tar.gz
+*.rar
+
+# virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml
+hs_err_pid*
+
+### JetBrains+all ###
+# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider
+# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
+
+# User-specific stuff
+.idea/**/workspace.xml
+.idea/**/tasks.xml
+.idea/**/usage.statistics.xml
+.idea/**/dictionaries
+.idea/**/shelf
+
+# Generated files
+.idea/**/contentModel.xml
+
+# Sensitive or high-churn files
+.idea/**/dataSources/
+.idea/**/dataSources.ids
+.idea/**/dataSources.local.xml
+.idea/**/sqlDataSources.xml
+.idea/**/dynamic.xml
+.idea/**/uiDesigner.xml
+.idea/**/dbnavigator.xml
+
+# Gradle
+.idea/**/gradle.xml
+.idea/**/libraries
+
+# Gradle and Maven with auto-import
+# When using Gradle or Maven with auto-import, you should exclude module files,
+# since they will be recreated, and may cause churn.  Uncomment if using
+# auto-import.
+# .idea/artifacts
+# .idea/compiler.xml
+# .idea/jarRepositories.xml
+# .idea/modules.xml
+# .idea/*.iml
+# .idea/modules
+# *.iml
+# *.ipr
+
+# CMake
+cmake-build-*/
+
+# Mongo Explorer plugin
+.idea/**/mongoSettings.xml
+
+# File-based project format
+*.iws
+
+# IntelliJ
+out/
+
+# mpeltonen/sbt-idea plugin
+.idea_modules/
+
+# JIRA plugin
+atlassian-ide-plugin.xml
+
+# Cursive Clojure plugin
+.idea/replstate.xml
+
+# Crashlytics plugin (for Android Studio and IntelliJ)
+com_crashlytics_export_strings.xml
+crashlytics.properties
+crashlytics-build.properties
+fabric.properties
+
+# Editor-based Rest Client
+.idea/httpRequests
+
+# Android studio 3.1+ serialized cache file
+.idea/caches/build_file_checksums.ser
+
+### JetBrains+all Patch ###
+# Ignores the whole .idea folder and all .iml files
+# See https://github.com/joeblau/gitignore.io/issues/186 and https://github.com/joeblau/gitignore.io/issues/360
+
+.idea/
+
+# Reason: https://github.com/joeblau/gitignore.io/issues/186#issuecomment-249601023
+
+*.iml
+modules.xml
+.idea/misc.xml
+*.ipr
+
+# Sonarlint plugin
+.idea/sonarlint
+
+### Maven ###
+target/
+pom.xml.tag
+pom.xml.releaseBackup
+pom.xml.versionsBackup
+pom.xml.next
+release.properties
+dependency-reduced-pom.xml
+buildNumber.properties
+.mvn/timing.properties
+# https://github.com/takari/maven-wrapper#usage-without-binary-jar
+.mvn/wrapper/maven-wrapper.jar
+
+### VisualStudioCode ###
+.vscode/*
+!.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/launch.json
+!.vscode/extensions.json
+*.code-workspace
+
+### VisualStudioCode Patch ###
+# Ignore all local history of files
+.history
+.ionide
+
+# End of https://www.toptal.com/developers/gitignore/api/visualstudiocode,maven,java,jetbrains+all

Jenkinsfile

@@ -1,32 +1,27 @@
 pipeline {
     agent any
 
+    tools {
+        maven "maven_jenkins"
+    }
+
     stages {
         stage ('Compile Stage') {
-
             steps {
-                withMaven(maven : 'maven_3_5_0') {
-                    sh 'mvn clean install'
+                sh 'mvn clean compile'
             }
         }
-        }
-
         stage ('Testing Stage') {
-
             steps {
-                withMaven(maven : 'maven_3_5_0') {
                     sh 'mvn test'
             }
         }
-        }
 
-        stage('Generate HTML report') {
+        stage ('Installing Stage') {
             steps {
-                cucumber buildStatus: "UNSTABLE",
-                        fileIncludePattern: '**/cucumber.json',
-                        jsonReportDirectory: 'target'
+                    sh 'mvn install'
+            }
         }
         
     }
-    }
 }

README.md

@@ -4,3 +4,6 @@
 - if the number is divisible by 3, you say Fizz
 - if the number is divisible by 5, you say Buzz
 - if neither, you say the number
+
+### Contributors
+This a Jenkinsfile Multibranch pipeline example

pom.xml

@@ -6,12 +6,14 @@
 
     <groupId>com.techprimers.testing</groupId>
     <artifactId>jenkins-example</artifactId>
-    <version>1.0-SNAPSHOT</version>
+    <version>20201020</version>
 
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <java.version>1.8</java.version>
+        <junit.jupiter.version>5.0.0-M3</junit.jupiter.version>
+        <junit.platform.version>1.0.0-M3</junit.platform.version>
     </properties>
 
     <build>
@@ -29,9 +31,9 @@
                 <version>2.19</version>
                 <dependencies>
                     <dependency>
-                        <groupId>junit</groupId>
-                        <artifactId>junit</artifactId>
-                        <version>4.12</version>
+                        <groupId>org.junit.platform</groupId>
+                        <artifactId>junit-platform-surefire-provider</artifactId>
+                        <version>1.0.0-M3</version>
                     </dependency>
                 </dependencies>
             </plugin>
@@ -39,24 +41,27 @@
     </build>
 
     <dependencies>
-
         <dependency>
-            <groupId>info.cukes</groupId>
-            <artifactId>cucumber-java</artifactId>
-            <version>1.2.5</version>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter-engine</artifactId>
+            <version>5.0.0-M3</version>
+            <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>info.cukes</groupId>
-            <artifactId>cucumber-junit</artifactId>
-            <version>1.2.5</version>
+            <groupId>org.junit.platform</groupId>
+            <artifactId>junit-platform-runner</artifactId>
+            <version>${junit.platform.version}</version>
         </dependency>
-
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.12</version>
+            <groupId>org.seleniumhq.selenium</groupId>
+            <artifactId>selenium-java</artifactId>
+            <version>4.0.0-alpha-6</version>
+        </dependency>
+        <dependency>
+            <groupId>org.seleniumhq.selenium</groupId>
+            <artifactId>selenium-api</artifactId>
+            <version>4.0.0-alpha-6</version>
         </dependency>
-
     </dependencies>
 
     <repositories>

src/main/java/com/techprimers/testing/FizzBuzz.java

@@ -5,16 +5,10 @@ public class FizzBuzz {
     public String play(int number) {
 
         if (number == 0) throw new IllegalArgumentException("Number must not be 0");
-
-        if (isMultipleOf(number, 3) && isMultipleOf(number, 5)) return "FizzBuzz";
-        if (isMultipleOf(number, 3)) return "Fizz";
-        if (isMultipleOf(number, 5)) return "Buzz";
+        if (number % 3 == 0) return "Fizz";
+        if (number % 5 == 0) return "Buzz";
 
 
         return String.valueOf(number);
     }
-
-    private boolean isMultipleOf(int number, int i) {
-        return number % i == 0;
-    }
 }

src/test/java/com/techprimers/testing/CucumberTest.java

@@ -1,14 +0,0 @@
-package com.techprimers.testing;
-
-import cucumber.api.CucumberOptions;
-import cucumber.api.junit.Cucumber;
-import org.junit.runner.RunWith;
-
-@RunWith(Cucumber.class)
-@CucumberOptions(
-        features = "src/test/resources",
-        glue = "com.techprimers.testing",
-        format = {"json:target/cucumber.json"}
-)
-public class CucumberTest {
-}

src/test/java/com/techprimers/testing/FizzBuzzStepdefs.java

@@ -1,26 +0,0 @@
-package com.techprimers.testing;
-
-import cucumber.api.java.en.Given;
-import cucumber.api.java.en.Then;
-import cucumber.api.java.en.When;
-import org.junit.Assert;
-public class FizzBuzzStepdefs {
-
-    FizzBuzz fizzBuzz;
-    String result;
-
-    @Given("^Create a FizzBuzz game play$")
-    public void createAFizzBuzzGamePlay() throws Throwable {
-        fizzBuzz = new FizzBuzz();
-    }
-
-    @When("^I play with number (\\d+)$")
-    public void iPlayWithNumber(int number) throws Throwable {
-        result = fizzBuzz.play(number);
-    }
-
-    @Then("^The result is \"([^\"]*)\"$")
-    public void theResultIs(String resultString) throws Throwable {
-        Assert.assertEquals(result, resultString);
-    }
-}

src/test/java/com/techprimers/testing/FizzBuzzTest.java

@@ -1,51 +1,46 @@
 package com.techprimers.testing;
 
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.*;
 
-public class FizzBuzzTest {
+class FizzBuzzTest {
 
     public FizzBuzz fB;
 
-//    @
-    @Before
+    @BeforeEach
     public void setUp() {
         fB = new FizzBuzz();
     }
 
-//    @DisplayName("Play FizzBuzz with number = 1")
+    @DisplayName("Play FizzBuzz with number = 1")
     @Test
     public void testNumber() {
         String fizzBuzz = fB.play(1);
-        Assert.assertEquals(fizzBuzz, "1");
+        Assertions.assertEquals(fizzBuzz, "1");
     }
 
-//    @DisplayName("Play FizzBuzz with number = 3")
+    @DisplayName("Play FizzBuzz with number = 3")
     @Test
     public void testFizz() {
         String fizzBuzz = fB.play(3);
-        Assert.assertEquals(fizzBuzz, "Fizz");
+        Assertions.assertEquals(fizzBuzz, "Fizz");
     }
 
-//    @DisplayName("Play FizzBuzz with number = 5")
+    @DisplayName("Play FizzBuzz with number = 5")
     @Test
     public void testBuzz() {
         String fizzBuzz = fB.play(5);
-        Assert.assertEquals(fizzBuzz, "Buzz");
+        Assertions.assertEquals(fizzBuzz, "Buzz");
     }
 
-//    @DisplayName("Don't Play FizzBuzz with number = 0")
-//    @Test
-//    public void testZero() {
-//
-//        Assert.assertThat(IllegalArgumentException.class,
-//                () -> fB.play(0));
-//    }
+    @DisplayName("Don't Play FizzBuzz with number = 0")
+    @Test
+    public void testZero() {
 
-//    @AfterEach
-    @After
+        Assertions.assertThrows(IllegalArgumentException.class,
+                () -> fB.play(0));
+    }
+
+    @AfterEach
     public void tearDown() {
         fB = null;
     }

src/test/resources/FizzBuzz.feature

@@ -1,16 +0,0 @@
-Feature: FizzBuzz Game play
-
-  Scenario: Play FizzBuzz to get Fizz
-    Given Create a FizzBuzz game play
-    When I play with number 3
-    Then The result is "Fizz"
-
-  Scenario: Play FizzBuzz to get Buzz
-    Given Create a FizzBuzz game play
-    When I play with number 5
-    Then The result is "Buzz"
-
-  Scenario: Play FizzBuzz to get FizzBuzz
-    Given Create a FizzBuzz game play
-    When I play with number 15
-    Then The result is "FizzBuzz"