From 4b0503b6221cc825c4ff42ae0d425d940be49e6d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benedikt=20R=C3=B6tsch?=
 <axe312ger@users.noreply.github.com>
Date: Thu, 9 Nov 2017 11:25:02 +0100
Subject: [PATCH] Fix breadcrumb and add test for locales (#49)

* test(unit): add test to check for locale consistency

* fix(breadcrumb): translate lessons route
---
 i18n/locales/de-DE.json   |  2 +-
 i18n/locales/en-US.json   |  1 -
 lib/enhance-breadcrumb.js |  2 +-
 test/unit/locales.test.js | 11 +++++++++++
 4 files changed, 13 insertions(+), 3 deletions(-)
 create mode 100644 test/unit/locales.test.js

diff --git a/i18n/locales/de-DE.json b/i18n/locales/de-DE.json
index 4be17f1..076861f 100644
--- a/i18n/locales/de-DE.json
+++ b/i18n/locales/de-DE.json
@@ -17,6 +17,7 @@
   "logoAlt": "Die Beispielanwendung für Contentful",
   "homeLabel": "Startseite",
   "coursesLabel": "Kurse",
+  "lessonsLabel": "Lektionen",
   "footerDisclaimer": "Powered by Contentful. Diese Website und deren Materialien existieren nur für Demonstrationszwecken. Sie können diese benutzen, um den Inhalt ihres Contentful Kontos anzusehen.",
   "imprintLabel": "Impressum",
   "contactUsLabel": "Kontakt",
@@ -74,7 +75,6 @@
   "fieldIsRequiredLabel": "Diese Feld ist notwendig.",
   "deliveryKeyInvalidLabel": "Ihr Delivery API Zugangsschlüssel ist ungültig.",
   "spaceOrTokenInvalid": "Dieser Space existiert nicht, oder Ihr Access Token kommt nicht von diesem Space.",
-  "somethingWentWrongLabel": "Irgendetwas lief falsch.",
   "previewKeyInvalidLabel": "Ihr Preview API Zugangsschlüssel ist ungültig.",
   "beginnerLabel": "Anfänger",
   "intermediateLabel": "Fortgeschrittener",
diff --git a/i18n/locales/en-US.json b/i18n/locales/en-US.json
index ec01ce9..aae37af 100644
--- a/i18n/locales/en-US.json
+++ b/i18n/locales/en-US.json
@@ -75,7 +75,6 @@
   "fieldIsRequiredLabel": "This field is required",
   "deliveryKeyInvalidLabel": "Your Delivery API key is invalid.",
   "spaceOrTokenInvalid": "This space does not exist or your access token is not associated with your space.",
-  "somethingWentWrongLabel": "Something went wrong",
   "previewKeyInvalidLabel": "Your Preview API key is invalid.",
   "beginnerLabel": "Beginner",
   "intermediateLabel": "Intermediate",
diff --git a/lib/enhance-breadcrumb.js b/lib/enhance-breadcrumb.js
index d13bf9b..d325f0b 100644
--- a/lib/enhance-breadcrumb.js
+++ b/lib/enhance-breadcrumb.js
@@ -2,7 +2,7 @@ module.exports = (request, resource) => {
   const breadcrumbs = request.app.locals.breadcrumb
 
   let enhancedBreadcrumbs = breadcrumbs.map((breadcrumb) => {
-    if (breadcrumb.label.replace(/ /g, '-') == resource.fields.slug) {
+    if (breadcrumb.label.replace(/ /g, '-') === resource.fields.slug) {
       breadcrumb.label = resource.fields.title
     }
     return breadcrumb
diff --git a/test/unit/locales.test.js b/test/unit/locales.test.js
new file mode 100644
index 0000000..d177c71
--- /dev/null
+++ b/test/unit/locales.test.js
@@ -0,0 +1,11 @@
+const germanLocales = require('../../i18n/locales/de-DE.json')
+const englishLocales = require('../../i18n/locales/en-US.json')
+
+describe('locales', () => {
+  test('all labels coexist in all locale files', async () => {
+    const germanKeys = Object.keys(germanLocales)
+    const englishKeys = Object.keys(englishLocales)
+
+    expect(germanKeys).toEqual(englishKeys)
+  })
+})