Agile611/the-example-app-nodejs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Minor fixes (#73)

Browse Source 
* feat: Address JPs Feedback

* fix: settings config

* fix: fix tests
This commit is contained in:
Khaled Garbaya
2017-11-30 12:46:30 +01:00
committed by GitHub
parent ffc2df6a41
commit b456500c9f
9 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
views/layout.pug
View File

@@ -136,7 +136,7 @@ html
| .
p
| #{translate('modalSpaceIntro', currentLocale.code)} 
a(href='https://github.com/contentful/content-models/tree/master/the-example-app' target='_blank' rel='noopener')=translate('modalSpaceLinkLabel', currentLocale.code)
a(href='https://github.com/contentful/content-models/blob/master/the-example-app/README.md ' target='_blank' rel='noopener')=translate('modalSpaceLinkLabel', currentLocale.code)
| .
.modal__cta-wrapper
a(href='#').modal__cta.close #{translate('modalCTALabel', currentLocale.code)}

20
views/mixins/_moduleHighlightedCourse.pug
View File

@@ -1,17 +1,17 @@
include ./_courseCard
mixin moduleHighlightedCourse(module, course)
.module.module-higlighted-course
.module-higlighted-course__wrapper(style=`background-image: url(${course.fields.image.fields.file.url});`)
.module-higlighted-course__overlay
.module-higlighted-course__content
.module.module-highlighted-course
.module-highlighted-course__wrapper(style=`background-image: url(${course.fields.image.fields.file.url});`)
.module-highlighted-course__overlay
.module-highlighted-course__content
if(course.fields.categories)
.module-higlighted-course__categories
.module-highlighted-course__categories
each category in course.fields.categories
a.module-higlighted-course__category(href=`/courses/categories/${category.fields.slug}${queryString}`) #{category.fields.title}
h2.module-higlighted-course__title
a.module-highlighted-course__category(href=`/courses/categories/${category.fields.slug}${queryString}`) #{category.fields.title}
h2.module-highlighted-course__title
a(href=`/courses/${course.fields.slug}${queryString}`)= course.fields.title
.module-higlighted-course__description-wrapper
.module-highlighted-course__description-wrapper
p !{helpers.markdown(course.fields.shortDescription)}
.module-higlighted-course__link-wrapper
a.module-higlighted-course__link(href=`/courses/${course.fields.slug}${queryString}`) #{translate('viewCourseLabel', currentLocale.code)}
.module-highlighted-course__link-wrapper
a.module-highlighted-course__link(href=`/courses/${course.fields.slug}${queryString}`) #{translate('viewCourseLabel', currentLocale.code)}

1
views/settings.pug
View File

@@ -39,6 +39,7 @@ block content
form(action=`/settings` method="POST" class="form")
.form-item
input(type="hidden" name="qs" value=queryString)
label(for="input-space-id") #{translate('spaceIdLabel', currentLocale.code)}
input(type="text" name="spaceId" id="input-space-id" value=settings.spaceId)
if 'spaceId' in errors