Commit Graph

12 Commits

Author SHA1 Message Date
Khaled Garbaya
55f3c4e883 Fix Cookie Max Age (#74) 2017-12-01 14:00:47 +01:00
Benedikt Rötsch
0b509f2a29 fix(cookies): fix variable naming and extend to two days maxAge 2017-11-09 13:22:30 +01:00
Benedikt Rötsch
67b5d09a5c Fix breadcrumb and add test for locales (#49)
* test(unit): add test to check for locale consistency

* fix(breadcrumb): translate lessons route
2017-11-09 11:25:02 +01:00
David Litvak Bruno
1515d09dc2 Refactor entry state toggle (#48)
* chore(editorialFeatures): extract editorial features toggle

* chore(refactor): rename function to make more contextual sense
2017-11-09 11:24:07 +01:00
David Litvak Bruno
81577c82fd Enhance Breadcrumbs (#39)
* chore(localization): remove duplicated locale files

* feat(localization): add localization for breadcrumbs

* feat(localization): add beadcrumb enhancements

* feat(debugging): add npm run debug command

* chore(localization): add unit tests

* chore(breadcrumbs): fix tests and typos

* chore(localization): add docs for translationAvailable

* chore(localization): refactor translationAvailable
2017-11-08 15:39:24 +01:00
David Litvak Bruno
146c01643b feat(analytics): add analytics on deploy script (#32) 2017-11-07 17:33:32 +01:00
David Litvak
68a8052bdf feat(localization): add localization for static strings 2017-11-07 17:33:32 +01:00
Khaled Garbaya
9ae9c543ba feat: Change cookie age to 24h 2017-11-07 17:33:32 +01:00
JP Wright
cdb0a07ff7 Make changes to code to improve readability 2017-11-07 17:33:32 +01:00
Benedikt Rötsch
7ad2c1fa4f refactor: Cleanup (#21)
* refactor(routes): remove unused sitemap route

* style(comments): enforce consistent comment style

* style(exports): enforce consistent export style

* chore: Add jsDoc for contentful service

* chore: Add jsDoc for contentful service \n \n closes #23

* refactor(app): move query parameter comment to right position and mention comment route middleware

* test(npm): add temporary test script

* refactor(middlewares): split up bootstrap middleware - fixes #23759

* refactor(cookies): use constances to give context the maxAge cookie setting

* refactor(variables): use more descriptive names for variables

* space became spaceId when it was just the id not the full space instance
* all (access) token variable name variants became [api-type]Token
* all clients are now called deliveryClient or previewClient
* cpa and cda only remain when they are used as actual API id
* env variables names adjusted

* perf(helpers): only run marked when content is not empty

* refactor(comments): fix typos

* refactor(comments): add hint why error is logged to console in settings

* chore: Add comments to routes and services

* refactor(requires): order and group requires

* fix(settings): add validation for wrong preview token

* chore: Add comments to routes

* chore: fix typo

* chore: console.error -> throw

* chore: move cookie name to a constant

* chore: Fix app.js comment

* typo: removing t

* chore: typos

* chore: removed unnecessary comment line sign

* chore: newline for readabillity

* chore: remove dangling `t`

* chore: remove `t`, add `l`

* chore: typos

* Fleshed out title

* build(npm): remove unused dependencies

* build(npm): upgrade to latest stable contentful sdk

* chore: Addressing David feedbak

* fix(credentials): update to match the new space

* chore: Addressing code review comments

* chore: Addressing code review comments

* chore: res -> response, req-> request

* chore: include exactly what we need

* chore: Address JPs comments

* chore: Address JPs comments

* chore: Address Fredericks comments

* chore: Address Fredericks comments

* fixup! chore: Address Fredericks comments

* fixup! fixup! chore: Address Fredericks comments

* fixup! fixup! fixup! chore: Address Fredericks comments

* fixup! fixup! fixup! fixup! chore: Address Fredericks comments

* fixup! fixup! fixup! fixup! fixup! chore: Address Fredericks comments

* fixup! fixup! fixup! fixup! fixup! fixup! chore: Address Fredericks comments
2017-11-07 17:33:32 +01:00
Benedikt Rötsch
fd52efd625 feat(entry-states): display entity state for editors 2017-11-07 17:33:32 +01:00
Khaled Garbaya
52de0d10f3 feat(breadcrumb): Add breadcrumb 2017-11-07 17:33:32 +01:00